Re: [PATCH v4 3/8] x86/fpu/xstate: Add CET supervisor xfeature support

From: Ingo Molnar
Date: Thu Apr 03 2025 - 10:07:41 EST



* Dave Hansen <dave.hansen@xxxxxxxxx> wrote:

> On 4/1/25 10:15, Chang S. Bae wrote:
> > In V3, you moved this patch further back to position 8 out of 10. Now,
> > in this version, you've placed it at position 3 out of 8.
> >
> > This raises the question of whether you've fully internalized his advice.
>
> Uh huh.
>
> 1. Refactor/fix existing code
> 2. Add new infrastructure
> 3. Add new feature

The more detailed version is:

- fix bugs
- clean up code
- refactor code
- add new infrastructure
- add new features

Or in general, the patches are basically hierarchy-sorted by the
'utility/risk' factor to users, while removing net technological debt.

This is why *sometimes* we'll even do cleanups/refactoring before
fixes: a fix can become lower-risk if it's on top of a cleaner code
base.

Thanks,

Ingo