Re: [RFC PATCH 3/3] mm: Implement for_each_valid_pfn() for CONFIG_SPARSEMEM

From: David Woodhouse
Date: Thu Apr 03 2025 - 10:24:45 EST


On Thu, 2025-04-03 at 17:13 +0300, Mike Rapoport wrote:
>  
> > static inline bool first_valid_pfn(unsigned long *p_pfn)
> > {
> >   unsigned long pfn = *p_pfn;
> >   unsigned long nr = pfn_to_section_nr(pfn);
> >   struct mem_section *ms;
> >
> >   rcu_read_lock_sched();
> >
> >   while (nr <= __highest_present_section_nr) {
> >   ms = __pfn_to_section(pfn);
>
> Maybe move the declaration here:
>
>   struct mem_section *ms = __pfn_to_section(pfn);

Ack.

https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/for_each_valid_pfn


Attachment: smime.p7s
Description: S/MIME cryptographic signature