Re: [PATCH] Documentation/x86: Clarify naming of CPU features for /proc/cpuinfo
From: Naveen N Rao
Date: Thu Apr 03 2025 - 11:10:19 EST
On Thu, Apr 03, 2025 at 03:21:21PM +0200, Borislav Petkov wrote:
> On Thu, Apr 03, 2025 at 06:40:00PM +0530, Naveen N Rao wrote:
> > As far as I can tell, the script still processes cpufeatures.h but no
> > longer "generates" names. It simply picks names within double-quotes if
> > present. I don't think that is relevant for describing how the flags are
> > named anymore.
>
> It is relevant in a documentation file which is called cpuinfo.rst. Because
> this thing is somewhat of a magic - and Xen has even more magic there - so I'd
> like that file to explain the *whole* story.
Ok.
>
> > Regardless, please take another look at this and let me know if you
> > think this still doesn't read right, or is missing anything (the script
> > part, in particular). For reference, here is how the flag naming section
> > looks like with this patch:
>
> Tell you what: I'll take your text, put it in the file, edit it how I think it
> should like and send you a patch for you to ack. This'll save us a lot of
> time.
Sure, feel free to edit my patch as you see fit before applying. I am
fine if you want to retain the section about the script - it should
still be a minor edit, unless you want to rewrite other parts.
Thank you!
- Naveen