Re: [PATCH v4 1/2] dt-bindings: timer: Add NXP System Timer Module

[Daniel Lezcano]

On 03/04/2025 08:33, Ghennadi Procopciuc wrote:
> On 4/2/2025 12:07 PM, Daniel Lezcano wrote:
> [ ... ]
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    timer@4011c000 {
> > +        compatible = "nxp,s32g2-stm";
> > +        reg = <0x4011c000 0x3000>;
> > +        interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&clks 0x3b>;
> > +    };
>
> The S32G reference manual specifies two clocks for the STM module: one
> for the registers and another for the counter itself. Shouldn't both
> clocks be represented in the bindings?

AFAICS, there are two clocks as described in the documentation for the 
s32g2 page 843, section 23.7.3 Timer modules.

The module and the register clock are fed by the XBAR_DIV3_CLK which is 
an system clock always-on.

page 1994, 40.5.4 Clocking, the documentation says: "This module has no 
clocking considerations."

From my understanding, we should not describe the XBAR_DIV3_CLK as it 
is a system clock.


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog