Re: [PATCH v2 7/7] drm/virtio: implement userptr: add interval tree
From: Dmitry Osipenko
Date: Thu Apr 03 2025 - 12:45:15 EST
On 4/3/25 06:28, Huang, Honglei1 wrote:
>
> Hi Dmitry:
>
> Really sorry for missed this comment. Yes it can be done in UMD,
> actually the interval tree is used with the MMU notifier normally,
> it is for preventing create same MMU notifier for overlapped areas.
> Cause this version patch set doesn't have MMU notifier, removing
> interval tree is reasonable.
>
> Hi Demi:
> Adding interval tree can make virtio userptr has robust check, it can be
> done in UMD. And for AMD userptr driver, it is a SVM type driver, it has
> both interval tree and MMU notifier but userptr memory is moveable in
> it. No interval tree for Intel i386, not sure about the Intel XE driver.
>
> Maybe I can remove the interval tree in next version.
Great, thanks for the clarification. And no need to be sorry, it happens
to everyone on the ML :D
--
Best regards,
Dmitry