Re: [RFC net-next PATCH 10/13] net: macb: Support external PCSs

From: Russell King (Oracle)
Date: Thu Apr 03 2025 - 17:11:36 EST


On Thu, Apr 03, 2025 at 02:27:06PM -0400, Sean Anderson wrote:
> -static void macb_pcs_get_state(struct phylink_pcs *pcs,
> +static void macb_pcs_get_state(struct phylink_pcs *pcs, unsigned int neg_mode,
> struct phylink_link_state *state)
> {
> struct macb *bp = container_of(pcs, struct macb, phylink_sgmii_pcs);
>
> - phylink_mii_c22_pcs_decode_state(state, gem_readl(bp, PCSSTS),
> + phylink_mii_c22_pcs_decode_state(state, neg_mode, gem_readl(bp, PCSSTS),
> gem_readl(bp, PCSANLPBASE));

Looks like this should be in the previous patch.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!