RE: [PATCH v3 1/2] regulator: dt-bindings: adi,adp5055-regulator: Add adp5055 support
From: Torreno, Alexis Czezar
Date: Thu Apr 03 2025 - 22:34:21 EST
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Thursday, April 3, 2025 2:40 PM
> To: Torreno, Alexis Czezar <AlexisCzezar.Torreno@xxxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown
> <broonie@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 1/2] regulator: dt-bindings: adi,adp5055-regulator: Add
> adp5055 support
>
> [External]
>
> On Thu, Apr 03, 2025 at 10:43:10AM +0800, Alexis Czezar Torreno wrote:
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 0
> > +
> > +patternProperties:
> > + "^buck[0-2]$":
>
> If there is going to be new version, use consistent quotes, either " or '
>
> ...
>
> > + type: object
> > + $ref: regulator.yaml#
> > + unevaluatedProperties: false
>
> > + adi,fast-transient:
> > + description:
> > + Configures the fast transient sensitivity for each regulator.
> > + "none" - No fast transient.
> > + "3G_1.5%" - 1.5% window with 3*350uA/V
> > + "5G_1.5%" - 1.5% window with 5*350uA/V
> > + "5G_2.5%" - 2.5% window with 5*350uA/V
> > + enum: [none, 3G_1.5%, 5G_1.5%, 5G_2.5%]
> > + default: 5G_2.5
>
> Missing percent:
> 5G_2.5%
>
> With this fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Will fix the small edits.
Thanks!