Re: [PATCH v2] staging: rtl8723bs: Remove trailing whitespace

[Gabriel]

On Thu, Apr 3, 2025 at 10:22 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Apr 02, 2025 at 08:42:07AM -0400, Gabriel Shahrouzi wrote:
> > Remove trailing whitespace to comply with kernel coding style.
> >
> > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@xxxxxxxxx>
> > ---
> > Changes in v2:
> >       - Resend using git send-email to fix formatting issues in the email body.
> > ---
> >  drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git drivers/staging/rtl8723bs/include/hal_pwr_seq.h drivers/staging/rtl8723bs/include/hal_pwr_seq.h
> > index b93d74a5b9a5..48bf7f66a06e 100644
> > --- drivers/staging/rtl8723bs/include/hal_pwr_seq.h
> > +++ drivers/staging/rtl8723bs/include/hal_pwr_seq.h
>
> This wasn't made with git, was it?  You are "one" indent level off, the
> diff should say:
Interesting. Not entirely certain how this happened. Since it was from
an earlier commit I made, I rebased it, amended the changes, and then
formatted another patch using git. Apparently one of my other patches
for an earlier version had the same problem but the subsequent version
has the correct indent.
>
> --- a/drivers/staging/rtl8723bs/include/hal_pwr_seq.h
> +++ b/drivers/staging/rtl8723bs/include/hal_pwr_seq.h
>
> here, right?
Yes.
>
> Anyway, because of that, this does not apply to the tree at all :(
>
> Please fix and send a v3.
Got it.
>
> thanks,
>
> greg k-h

On Thu, Apr 3, 2025 at 10:22 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Apr 02, 2025 at 08:42:07AM -0400, Gabriel Shahrouzi wrote:
> > Remove trailing whitespace to comply with kernel coding style.
> >
> > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@xxxxxxxxx>
> > ---
> > Changes in v2:
> >       - Resend using git send-email to fix formatting issues in email body.
> > ---
> >  drivers/staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git drivers/staging/rtl8723bs/include/hal_pwr_seq.h drivers/staging/rtl8723bs/include/hal_pwr_seq.h
> > index b93d74a5b9a5..48bf7f66a06e 100644
> > --- drivers/staging/rtl8723bs/include/hal_pwr_seq.h
> > +++ drivers/staging/rtl8723bs/include/hal_pwr_seq.h
>
> This wasn't made with git, was it?  You are "one" indent level off, the
> diff should say:
>
> --- a/drivers/staging/rtl8723bs/include/hal_pwr_seq.h
> +++ b/drivers/staging/rtl8723bs/include/hal_pwr_seq.h
>
> here, right?
>
> Anyway, because of that, this does not apply to the tree at all :(
>
> Please fix and send a v3.
>
> thanks,
>
> greg k-h