Re: [PATCH] sound: soc: stm: stm32_sai: Use dev_err_probe()

From: Krzysztof Kozlowski
Date: Fri Apr 04 2025 - 02:13:15 EST


On 03/04/2025 09:41, shao.mingyin@xxxxxxxxxx wrote:
> From: Zhang Enpei <zhang.enpei@xxxxxxxxxx>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Zhang Enpei <zhang.enpei@xxxxxxxxxx>
> Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
> ---
The code was correct before 2cfe1ff22555 ("ASoC: stm32: sai: add
stm32mp25 support") and that commit broke it. Some explanation would be
useful instead of blindly generating patches.

Was it done on purpose like that in that commit? Or ST just sent
downstream commit to mainline without changing it?

Best regards,
Krzysztof