Re: [PATCH RESEND] staging: gpib: warning: variable 'nec_priv' set but not used warning

[Greg KH]

On Fri, Apr 04, 2025 at 02:11:35PM +0800, sunliming@xxxxxxxxx wrote:
> From: sunliming <sunliming@xxxxxxxxxx>
> 
> Fix below kernel warning:
> drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not
> used [-Wunused-but-set-variable]
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503200532.B4rXNs0N-lkp@xxxxxxxxx/
> Signed-off-by: sunliming <sunliming@xxxxxxxxxx>
> ---
>  drivers/staging/gpib/eastwood/fluke_gpib.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
> index 0304c5de4ccd..6854a745ccff 100644
> --- a/drivers/staging/gpib/eastwood/fluke_gpib.c
> +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
> @@ -194,10 +194,8 @@ static int fluke_line_status(const gpib_board_t *board)
>  	int status = ValidALL;
>  	int bsr_bits;
>  	struct fluke_priv *e_priv;
> -	struct nec7210_priv *nec_priv;
>  
>  	e_priv = board->private_data;
> -	nec_priv = &e_priv->nec7210_priv;
>  
>  	bsr_bits = fluke_paged_read_byte(e_priv, BUS_STATUS, BUS_STATUS_PAGE);
>  
> -- 
> 2.25.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot