Re: [PATCH v9 3/4] arm64: defconfig: add S32G RTC module support
From: Krzysztof Kozlowski
Date: Fri Apr 04 2025 - 03:15:52 EST
On 04/04/2025 08:24, Ciprian Marian Costea wrote:
> On 4/4/2025 9:17 AM, Krzysztof Kozlowski wrote:
>> On 03/04/2025 12:33, Ciprian Costea wrote:
>>> From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>
>>>
>>> The RTC hardware module present on S32G based SoCs tracks clock time
>>> during system suspend and it is used as a wakeup source on S32G2/S32G3
>>> architecture.
>> Which boards are using it? I don't see any DTS (nowhere), so I do not
>> see single reason for this patch.
>>
>> Best regards,
>> Krzysztof
>
> The RTC module is used by all the currently supported S32G2/S32G3
> boards, so currently they are: S32G274A-EVB, S32G274A-RDB2, S32G399A-RDB3.
I don't think so. I looked at these DTS and there is no RTC.
> I do see your point in the fact that this driver should be enabled as
> module only after platforms are actually using it.
No, post the user. I don't see the point of sending defconfig patch with
RTC patchset anyway. That's different subsystem.
>
> So, would it be better for me to send a V10 in this series with the DTS
> patch added ?
No, separate patchsets.
Best regards,
Krzysztof