Re: [v4] staging: rtl8723bs: modify struct field to use standard bool type

From: Greg KH
Date: Fri Apr 04 2025 - 04:02:34 EST


On Fri, Apr 04, 2025 at 08:51:59AM +0100, Abraham Samuel Adekunle wrote:
> The struct sta_info field ieee8021x_blocked uses the uint values
> 0 and 1 to represent false and true values respectively.

Nit, you don't say "PATCH" in the subject line, why not?

>
> Convert cases to use the bool type instead to ensure consistency
> with other parts of the containing code where true or false have
> been used.
>
> This change causes the struct field to change size from a 32bit to
> an 8bit. However, the change is safe to make because the sta_info
> struct is not read from the hardware.
>
> reported by Coccinelle:

Shouldn't something come after a ":"?

thanks,

greg k-h