Re: [PATCH v2] fs: make generic_fillattr() tail-callable and utilize it in ext2/ext4

[Christoph Hellwig]

On Tue, Apr 01, 2025 at 06:52:52PM +0200, Mateusz Guzik wrote:
> Unfortunately the other filesystems I checked make adjustments after
> their own call to generic_fillattr() and consequently can't benefit.

This is in no way a useful commit message.

Why do you even do this change?  What's the point of it?  And why do you
think making a function tail callable for two callers, one of which is
basically irrelevant warrants adding a pointless return that now needs
to be generated and checked by all other callers (which this patch fails
to do)?