Re: [PATCH v4 1/1] staging: rtl8723bs: Prevent duplicate NULL tests on a value

From: Andy Shevchenko
Date: Fri Apr 04 2025 - 06:55:43 EST


On Fri, Apr 4, 2025 at 11:51 AM Abraham Samuel Adekunle
<abrahamadekunle50@xxxxxxxxx> wrote:

...

> While at it, convert '& 0xfff' cases to use modulo operator and
> decimal number to make the upper limit visible and clear what the
> semantic of it is.

I think there is a consensus now that this should be a separate followup change.

...

> + psta->sta_xmitpriv.txseq_tid[pattrib->priority] &= 0xFFF;

This also has the same semantic and may be changed in that patch.

--
With Best Regards,
Andy Shevchenko