Re: [PATCH net v2 1/7] net: hibmcge: fix incorrect pause frame statistics issue

[Simon Horman]

On Thu, Apr 03, 2025 at 09:53:05PM +0800, Jijie Shao wrote:
> The driver supports pause frames,
> but does not pass pause frames based on rx pause enable configuration,
> resulting in incorrect pause frame statistics.
> 
> like this:
> mz eno3 '01 80 c2 00 00 01 00 18 2d 04 00 9c 88 08 00 01 ff ff' \
> 	-p 64 -c 100
> 
> ethtool -S enp132s0f2 | grep -v ": 0"
> NIC statistics:
>      rx_octets_total_filt_cnt: 6800
>      rx_filt_pkt_cnt: 100
> 
> The rx pause frames are filtered by the MAC hardware.
> 
> This patch configures pass pause frames based on the
> rx puase enable status to ensure that
> rx pause frames are not filtered.
> 
> mz eno3 '01 80 c2 00 00 01 00 18 2d 04 00 9c 88 08 00 01 ff ff' \
>         -p 64 -c 100
> 
> ethtool --include-statistics -a enp132s0f2
> Pause parameters for enp132s0f2:
> Autonegotiate:	on
> RX:		on
> TX:		on
> RX negotiated: on
> TX negotiated: on
> Statistics:
>   tx_pause_frames: 0
>   rx_pause_frames: 100
> 
> Fixes: 3a03763f3876 ("net: hibmcge: Add pauseparam supported in this module")
> Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> ---
> ChangeLog:
> v1 -> v2:
>   - Add more details in commit log, suggested by Simon Horman.
>   v1: https://lore.kernel.org/all/20250402133905.895421-1-shaojijie@xxxxxxxxxx/

Thanks for the update.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>