Re: [PATCH v3 2/2] regulator: adp5055: Add driver for adp5055

[Mark Brown]

On Fri, Apr 04, 2025 at 02:33:27AM +0000, Torreno, Alexis Czezar wrote:

> > This is absolutely standard enable GPIO support, just let the core handle
> > everything.  Otherwise this looks fine.

> May I ask which core function is the suggested to use here?

> I assume I need to change the line in ops:
> -> .is_enabled = adp5055_is_enabled,

> Not sure which function handles both GPIO and registers since as far as I
> understand 'regulator_is_enabled_regmap()' only handles software/registers and
> 'regulator_is_enabled()' only checks the gpio?

The core handles GPIOs separately to the enable function, this is a very
standard feature even things that actually need custom enable functions
can make use of it.

Attachment: signature.asc
Description: PGP signature