Re: [PATCH 1/3] arm64: dts: qcom: x1e80100-hp-omnibook-x14: Create and include a dtsi

[Krzysztof Kozlowski]

On 04/04/2025 11:01, Juerg Haefliger wrote:
> Create a dtsi for the HP OmniBook so it can be reused for the HP EliteBook
> which seems to be the same HW.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@xxxxxxxxxxxxx>
> ---
>  .../dts/qcom/x1e80100-hp-omnibook-x14.dts     | 1554 +---------------
>  .../dts/qcom/x1e80100-hp-omnibook-x14.dtsi    | 1557 +++++++++++++++++
>  2 files changed, 1558 insertions(+), 1553 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtsi

Very difficult to review. This should have been rename. You are not
using b4, so you can tweak -M/-B/-C parameters.


I also do not understand what the DTSI represents. The DTSI files should
be some sort of common hardware, design, product. Are you sure these
devices share the design?

Best regards,
Krzysztof