Re: [PATCH v3 1/4] kernel/resource: Provide mem region release for SOFT RESERVES

[Andy Shevchenko]

On Fri, Apr 04, 2025 at 02:16:39PM +0100, Jonathan Cameron wrote:
> On Thu, 3 Apr 2025 13:33:12 -0500 Terry Bowman <terry.bowman@xxxxxxx> wrote:

> > Add a release_Sam_region_adjustable() interface to allow for
> 
> Who is Sam?  (typo)

Somebody's uncle?

...

> >  #ifdef CONFIG_MEMORY_HOTREMOVE
> >  extern void release_mem_region_adjustable(resource_size_t, resource_size_t);
> >  #endif
> > +#ifdef CONFIG_CXL_REGION
> > +extern void release_srmem_region_adjustable(resource_size_t, resource_size_t);
> I'm not sure the srmem is obvious enough.  Maybe it's worth the long
> name to spell it out some more.. e.g. something like

And perhaps drop 'extern' as it's not needed.

> extern void release_softresv_mem_region_adjustable() ?

> >  #ifdef CONFIG_MEMORY_HOTPLUG
> >  extern void merge_system_ram_resource(struct resource *res);
> >  #endif

-- 
With Best Regards,
Andy Shevchenko