Re: [PATCH] exit: skip IRQ disabled warning during power off

[Oleg Nesterov]

On 04/04, Breno Leitao wrote:
>
> On Fri, Apr 04, 2025 at 04:16:24PM +0200, Oleg Nesterov wrote:
> > On 04/04, Breno Leitao wrote:
> > >
> > > 	[  254.474273] reboot: Power down
> > > 	[  254.479332] ------------[ cut here ]------------
> > > 	[  254.479934] WARNING: CPU: 0 PID: 1 at kernel/exit.c:881 do_exit (kernel/exit.c:881)
> >                                        ^^^^^^
> > confused... so it seems that the init task does
> > sys_reboot(LINUX_REBOOT_CMD_POWER_OFF) and exits?
> >
> > But if the init task exits for any reason it should trigger
> >
> > 	if (unlikely(is_global_init(tsk)))
> > 		panic("Attempted to kill init! exitcode=0x%08x\n"
>
> That is showing up later

OK, and this proves that we have more problems than just this WARN_ON().

Again, this is not my area, most probably I am wrong, but it seems to me
that do_exit() simply should not be called.

> We are discussing it on the other thread.
...
> Let's move this discussion to that thread, please.

Which thread? I wasn't cc'ed...

Oleg.