Re: [PATCH v8 03/16] CXL/AER: Introduce Kfifo for forwarding CXL errors

From: Jonathan Cameron
Date: Fri Apr 04 2025 - 12:55:51 EST



> int cxl_ras_init(void)
> {
> - return cxl_cper_register_prot_err_work(&cxl_cper_prot_err_work);
> + int rc;
> +
> + rc = cxl_cper_register_prot_err_work(&cxl_cper_prot_err_work);
> + if (rc) {
> + pr_err("Failed to register CPER kfifo with AER driver");
> + return rc;
> + }
> +
> + rc = cxl_register_prot_err_work(&cxl_prot_err_work, cxl_create_prot_err_info);
> + if (rc) {
> + pr_err("Failed to register kfifo with AER driver");
> + return rc;
> + }
> +
> + return rc;
return 0;

Good to explicit if we know we can only get to a return with a particular
value.

> }
>
>