Re: [PATCH 3/3] crypto: x86 - Remove CONFIG_AS_AVX512

[Eric Biggers]

On Fri, Apr 04, 2025 at 07:55:40AM +0200, Uros Bizjak wrote:
> On Fri, Apr 4, 2025 at 3:51 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> >
> > On Fri, Apr 04, 2025 at 09:13:40AM +0800, kernel test robot wrote:
> > > Hi Uros,
> > >
> > > kernel test robot noticed the following build warnings:
> > >
> > > [auto build test WARNING on herbert-cryptodev-2.6/master]
> > > [also build test WARNING on herbert-crypto-2.6/master tip/x86/core linus/master v6.14]
> > > [cannot apply to next-20250403]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > >
> > > url:    https://github.com/intel-lab-lkp/linux/commits/Uros-Bizjak/crypto-x86-Remove-CONFIG_AS_SHA256_NI/20250403-174814
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> > > patch link:    https://lore.kernel.org/r/20250403094527.349526-3-ubizjak%40gmail.com
> > > patch subject: [PATCH 3/3] crypto: x86 - Remove CONFIG_AS_AVX512
> > > config: i386-buildonly-randconfig-001-20250404 (https://download.01.org/0day-ci/archive/20250404/202504040855.mr885Pz1-lkp@xxxxxxxxx/config)
> > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250404/202504040855.mr885Pz1-lkp@xxxxxxxxx/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202504040855.mr885Pz1-lkp@xxxxxxxxx/
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> lib/raid6/recov_avx512.c:382:2: warning: #warning "your version of binutils lacks AVX512 support" [-Wcpp]
> > >      382 | #warning "your version of binutils lacks AVX512 support"
> > >          |  ^~~~~~~
> > >
> > >
> > > vim +382 lib/raid6/recov_avx512.c
> > >
> > > 13c520b2993c9fa Gayatri Kammela 2016-08-12  380
> > > 13c520b2993c9fa Gayatri Kammela 2016-08-12  381  #else
> > > 13c520b2993c9fa Gayatri Kammela 2016-08-12 @382  #warning "your version of binutils lacks AVX512 support"
> >
> > Yeah, CONFIG_AS_AVX512 needs to be removed from lib/raid6/ too.  It looked like
> > that directory was rolling its own CONFIG_AS_AVX512 in lib/raid6/test/Makefile,
> > but that's a makefile for a test program and not the actual kernel makefile.
> 
> I think the best approach to avoid patch dependencies is not to remove
> the test for AS_AVX512 from Kconfig.assembler in this patch, but in a
> separate patch that will be eventually committed late in the merge
> cycle (or for the next version), after all other users are removed
> from the tree. I have patches for other parts ready.
> 
> I'll post v2 of this series with the above adjustment.
> 

$ ./scripts/get_maintainer.pl lib/raid6/avx512.c
linux-kernel@xxxxxxxxxxxxxxx (open list)

Whee, more unmaintained code...

I think it would be okay to just update lib/raid6/ in the same patch.

But if you want to wait for the next cycle that's fine too.

- Eric