Re: [PATCH 6/5] sched_ext: Drop "ops" from SCX_OPS_TASK_ITER_BATCH

[Andrea Righi]

On Fri, Apr 04, 2025 at 09:12:08AM -1000, Tejun Heo wrote:
> The tag "ops" is used for two different purposes. First, to indicate that
> the entity is directly related to the operations such as flags carried in
> sched_ext_ops. Second, to indicate that the entity applies to something
> global such as enable or bypass states. The second usage is historical and
> causes confusion rather than clarifying anything. For example,
> scx_ops_enable_state enums are named SCX_OPS_* and thus conflict with
> scx_ops_flags. Let's drop the second usages.
> 
> Drop "ops" from SCX_OPS_TASK_ITER_BATCH.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Suggested-by: Andrea Righi <arighi@xxxxxxxxxx>

Looks good.

Acked-by: Andrea Righi <arighi@xxxxxxxxxx>

Thanks,
-Andrea

> ---
>  kernel/sched/ext.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -26,7 +26,7 @@ enum scx_consts {
>  	 * Iterating all tasks may take a while. Periodically drop
>  	 * scx_tasks_lock to avoid causing e.g. CSD and RCU stalls.
>  	 */
> -	SCX_OPS_TASK_ITER_BATCH		= 32,
> +	SCX_TASK_ITER_BATCH		= 32,
>  };
>  
>  enum scx_exit_kind {
> @@ -1401,15 +1401,15 @@ static void scx_task_iter_stop(struct sc
>   * @iter: iterator to walk
>   *
>   * Visit the next task. See scx_task_iter_start() for details. Locks are dropped
> - * and re-acquired every %SCX_OPS_TASK_ITER_BATCH iterations to avoid causing
> - * stalls by holding scx_tasks_lock for too long.
> + * and re-acquired every %SCX_TASK_ITER_BATCH iterations to avoid causing stalls
> + * by holding scx_tasks_lock for too long.
>   */
>  static struct task_struct *scx_task_iter_next(struct scx_task_iter *iter)
>  {
>  	struct list_head *cursor = &iter->cursor.tasks_node;
>  	struct sched_ext_entity *pos;
>  
> -	if (!(++iter->cnt % SCX_OPS_TASK_ITER_BATCH)) {
> +	if (!(++iter->cnt % SCX_TASK_ITER_BATCH)) {
>  		scx_task_iter_unlock(iter);
>  		cond_resched();
>  		scx_task_iter_relock(iter);