Re: [PATCH v16 04/15] dt-bindings: pci: pci-msi: Add support for PCI Endpoint msi-map

From: Frank Li
Date: Fri Apr 04 2025 - 16:33:28 EST


On Fri, Apr 04, 2025 at 03:11:40PM -0500, Rob Herring wrote:
> On Fri, Apr 04, 2025 at 03:01:05PM -0400, Frank Li wrote:
> > Document the use of msi-map for PCI Endpoint (EP) controllers, which can
> > use MSI as a doorbell mechanism. Each EP controller can support up to 8
> > physical functions and 65,536 virtual functions.
> >
> > Define how to construct device IDs using function bits [2:0] and virtual
> > function index bits [31:3], enabling msi-map to associate each child device
> > with a specific msi-specifier.
> >
> > Include a device tree example illustrating this configuration.
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > change from v15 to v16
> > - new patch
> > ---
> > Documentation/devicetree/bindings/pci/pci-msi.txt | 51 +++++++++++++++++++++++
> > 1 file changed, 51 insertions(+)
>
> Please don't add to .txt files.

where should put?

Suggest by Marc Zyngier <maz@xxxxxxxxxx>

"- Documentation: the msi-map property usage is undefined outside of a
PCIe RC, and the way you describe its use is so vague I read
anything in it. Please update
Documentation/devicetree/bindings/pci/pci-msi.txt to reflect the new
use case."

https://lore.kernel.org/all/86ldtpot6m.wl-maz@xxxxxxxxxx/

Frank

>
> Rob