Re: [PATCH v3 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

[Krzysztof Kozlowski]

On 04/04/2025 13:55, Ayushi Makhija wrote:
> Document DSI controller and phy on SA8775P platform.
> 
> Signed-off-by: Ayushi Makhija <quic_amakhija@xxxxxxxxxxx>
> ---
>  .../display/msm/qcom,sa8775p-mdss.yaml        | 183 +++++++++++++++++-
>  1 file changed, 182 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> index 5fac3e266703..1be26137b7b6 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -52,12 +52,25 @@ patternProperties:
>          items:
>            - const: qcom,sa8775p-dp
>  
> +  "^dsi@[0-9a-f]+$":
> +    type: object
> +    additionalProperties: true
> +    properties:
> +      compatible:
> +        contains:
> +          enum:

huh?

> +            - qcom,sa8775p-dsi-ctrl
> +            - qcom,mdss-dsi-ctrl

This makes no sense and I am pretty sure it breaks everything and was
not tested.

All previous comments apply.


Best regards,
Krzysztof