Re: [PATCH v5] staging: rtl8723bs: Prevent duplicate NULL tests on a value

[Samuel Abraham]

On Sat, Apr 5, 2025 at 2:30 PM Julia Lawall <julia.lawall@xxxxxxxx> wrote:
>
>
>
> On Sat, 5 Apr 2025, Abraham Samuel Adekunle wrote:
>
> > When a value has been tested for NULL in an expression, a
> > second NULL test on the same value in another expression
> > is unnecessary when the value has not been assigned to NULL.
> >
> > Remove unnecessary duplicate NULL tests on the same value
> > that has previously been tested.
> >
> > Found by Coccinelle.
>
> The changes are found in the same way, but the code patterns are overall
> quite different.  It could make sense to make separate patches for them.
> Then you could make a log message that is really specialized to the code
> in each patch and it would be easier for the reviewer to be convinced that
> you have done the right thing.

Thank you for the feedback Julia.
Okay how about the versioning. Should I make it like a Patchset?

Like [PATCH v6] with the cover letter and two patches, one for each code
pattern?

Thanks
Adekunle