Re: [PATCH] iwlwifi: mld: fix building with CONFIG_PM_SLEEP disabled

[Lukas Wunner]

On Sun, Mar 30, 2025 at 04:49:38AM +0000, Korenblit, Miriam Rachel wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxxxx>
> > Sent: Tuesday, 25 March 2025 10:44
> > 
> > The newly added driver causes multiple build problems when CONFIG_PM_SLEEP
> > is disabled:
[...]
> > --- a/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c
> > @@ -501,7 +501,7 @@ int iwl_mld_mac80211_start(struct ieee80211_hw *hw)
> >  		iwl_mld_restart_cleanup(mld);
> >  	}
> > 
> > -	if (!in_d3 || ret) {
> > +	if (!in_d3) {
> 
> Then where do you handle the in_d3 && ret case?

That seems to be a valid objection, yet Arnd's patch is now
commit 44605365f935 in wireless.git:

https://git.kernel.org/wireless/wireless/c/44605365f935

I'm proposing this v2:

https://lore.kernel.org/r/f435bd9c8186176ffa12fd3650fac71cacdeebe1.1743946314.git.lukas@xxxxxxxxx/

If wireless.git/main is a rebasing branch, consider replacing the
above-linked commit with the new version.  If it is not a rebasing
branch, let me know and I'll send a patch reinstating only the ret
in the if-condition.

Thanks,

Lukas