Re: [PATCH v3 14/32] mfd: sec: s2dos05/s2mpu05: use explicit regmap config and drop default

[Krzysztof Kozlowski]

On 03/04/2025 10:59, André Draszik wrote:
> When support for PMICs without compatibles was removed in
> commit f736d2c0caa8 ("mfd: sec: Remove PMICs without compatibles"),
> sec_regmap_config effectively became an orphan, because S5M8763X was
> the only user left of it before removal, using the default: case of the
> switch statement.
> 
> When s2dos05 and s2mpu05 support was added in commit bf231e5febcf
> ("mfd: sec-core: Add support for the Samsung s2dos05") and commit
> ed33479b7beb ("mfd: sec: Add support for S2MPU05 PMIC"), they ended up
> using that orphaned regmap_config in a non-obvious way due to the
> default: case of the device type switch matching statement taking
> effect again.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof