Re: [PATCH] wifi: mt76: mt7996: Fix null-ptr-deref in mt7996_mmio_wed_init()

[henry martin]

Ok, I will correct them in V2.

Regards,
Henry

Markus Elfring <Markus.Elfring@xxxxxx> 于2025年4月3日周四 18:13写道：
>
> …
> > Add NULL check after devm_ioremap() to prevent this issue.
>
> Can a summary phrase like “Prevent null pointer dereference in mt7996_mmio_wed_init()”
> be a bit nicer?
>
>
> …
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
> > @@ -323,6 +323,8 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
> >       wed->wlan.base = devm_ioremap(dev->mt76.dev,
> >                                     pci_resource_start(pci_dev, 0),
> >                                     pci_resource_len(pci_dev, 0));
> > +     if (!wed->wlan.base)
> > +             return -ENOMEM;
>
> Can a blank line be desirable after such a statement?
>
> Regards,
> Markus