[PATCH] cxl : fix cxlctl_validate_hw_command() warn: always true condition

From: xiaopeitux
Date: Sun Apr 06 2025 - 23:41:34 EST


From: Pei Xiao <xiaopei01@xxxxxxxxxx>

smatch warnings:
drivers/cxl/core/features.c:441 cxlctl_validate_hw_command()
warn: always true condition '(scope >= 0) => (0-u32max >= 0)'

remove always true condition.

Signed-off-by: Pei Xiao <xiaopei01@xxxxxxxxxx>
---
drivers/cxl/core/features.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
index f4daefe3180e..fdca93c984ce 100644
--- a/drivers/cxl/core/features.c
+++ b/drivers/cxl/core/features.c
@@ -616,9 +616,8 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs,
case CXL_MBOX_OP_GET_FEATURE:
if (cxl_mbox->feat_cap < CXL_FEATURES_RO)
return false;
- if (scope >= FWCTL_RPC_CONFIGURATION)
+ else
return true;
- return false;
case CXL_MBOX_OP_SET_FEATURE:
if (cxl_mbox->feat_cap < CXL_FEATURES_RW)
return false;
--
2.25.1