Re: [PATCH] clk: sophgo: Fixes Coccinelle/coccicheck warnings reported by do_div.cocci.

From: Inochi Amaoto
Date: Sun Apr 06 2025 - 23:56:06 EST


On Mon, Apr 07, 2025 at 11:21:46AM +0800, xiaopeitux@xxxxxxxxxxx wrote:
> From: Pei Xiao <xiaopei01@xxxxxxxxxx>
>
> cocci warnings:
> drivers/clk/sophgo/clk-sg2042-pll.c:217:1-7: WARNING:
> do_div() does a 64-by-32 division, please consider using div64_ul
> instead.
>
> drivers/clk/sophgo/clk-sg2042-pll.c:160:1-7: WARNING:
> do_div() does a 64-by-32 division, please consider using div64_u64
> instead.
>
> replace do_div() with div64_*() which doesn't implicitly cast the divisor.
>
> Signed-off-by: Pei Xiao <xiaopei01@xxxxxxxxxx>
> ---
> drivers/clk/sophgo/clk-sg2042-pll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

LGTM.

Reviewed-by: Inochi Amaoto <inochiama@xxxxxxxxx>