Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

[Kyrie Wu (吴晗)]

On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 09/01/2025 14:35, kyrie.wu wrote:
> > Add mediatek,mt8196-jpgdec compatible to binding document.
> 
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch -vX` helps here to create proper versioned
> patches. Another useful tool is b4. Skipping the PATCH keyword makes
> filtering of emails more difficult thus making the review process
> less
> convenient.
> 
> > 
> > Signed-off-by: kyrie.wu <kyrie.wu@xxxxxxxxxxxx>
> > ---
> >  ...5-jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} | 10
> > +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >  rename Documentation/devicetree/bindings/media/{mediatek,mt8195-
> > jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,multi-core-
> > jpegdec.yaml
> > similarity index 95%
> > rename from
> > Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > rename to Documentation/devicetree/bindings/media/mediatek,multi-
> > core-jpegdec.yaml
> 
> 
> Don't rename the file.
> 
> > index e5448c60e3eb..5ec98ddad506 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,multi-core-
> > jpegdec.yaml
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >  %YAML 1.2
> >  ---
> > -$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml*__;Iw!!CTRNKA9wMg0ARbw!lg1d9e5vm7JQRbUIRKg64b44cKCTOgxo8qiwE2QuYSBLcMHUaaFKbikp6yOXI4lvceYOAwLELlqtbQ$
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,multi-core-jpegdec.yaml*__;Iw!!CTRNKA9wMg0ARbw!lg1d9e5vm7JQRbUIRKg64b44cKCTOgxo8qiwE2QuYSBLcMHUaaFKbikp6yOXI4lvceYOAwJqmnSMWA$
> >  $schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lg1d9e5vm7JQRbUIRKg64b44cKCTOgxo8qiwE2QuYSBLcMHUaaFKbikp6yOXI4lvceYOAwIJtjn37Q$
> > 
> >  title: MediaTek JPEG Decoder
> > @@ -14,7 +14,9 @@ description:
> > 
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8195-jpgdec
> > +    enum:
> > +      - mediatek,mt8195-jpgdec
> > +      - mediatek,mt8196-jpgdec
> 
> Devices look compatible, so express it with fallback.
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

The MT8195 and MT8196 are both multi-hardware chips, I renamed the file
to treat it as a common file, if I don't do that it will need to
recreate a file with similar contents. Is this acceptable?
If the above description is acceptable, I will apply your request in
the next version.

Thanks.

Best regards,
Kyrie