Re: [PATCH v2] wifi: mt76: mt7915: Fix null-ptr-deref in mt7915_mmio_wed_init()

From: Markus Elfring
Date: Mon Apr 07 2025 - 04:00:49 EST



> Prevent null pointer dereference in mt7915_mmio_wed_init().

Can any other summary phrase variant become more desirable accordingly?



> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c

> @@ -678,6 +681,9 @@ int mt7915_mmio_wed_init(struct mt7915_dev *dev, void *pdev_ptr,
> wed->wlan.bus_type = MTK_WED_BUS_AXI;
> wed->wlan.base = devm_ioremap(dev->mt76.dev, res->start,
> resource_size(res));
> + if (!wed->wlan.base)
> + return -ENOMEM;
> +


Would the function “devm_platform_get_and_ioremap_resource” be applicable
in this else branch?
https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/base/platform.c#L87

Regards,
Markus