Re: [PATCH v8] ufs: core: Add WB buffer resize support
From: Huan Tang
Date: Mon Apr 07 2025 - 04:58:24 EST
> you must ensure the mode en_mode is within valid range (0-2), why not
> use enum?
>
>
> > +{
> > + int ret;
> > + u8 index;
> > +
> > + index = ufshcd_wb_get_query_index(hba);
> > + ret = ufshcd_query_attr_retry(hba,
> > UPIU_QUERY_OPCODE_WRITE_ATTR,
> > + QUERY_ATTR_IDN_WB_BUF_RESIZE_EN,
> > index, 0, &en_mode);
> > + if (ret)
> > + dev_err(hba->dev, "%s: Enable WB buf resize operation
> > failed %d\n",
> > + __func__, ret);
> > +
> > + return ret;
> > +
Bean sir,
Thanks for you reply!
Is the patch below okay?
https://lore.kernel.org/all/20250407085143.173-1-tanghuan@xxxxxxxx/