Re: [PATCH 06/12] gpio: f7188: use new line value setter callbacks

[Andy Shevchenko]

On Mon, Apr 07, 2025 at 09:13:15AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.

...

> -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value);
> +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +			   int value);

Same comment, I suggest you to correct editor configuration to make sure
80 is 80 and not seventy something.

...

> -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +			   int value)

Ditto.

...

But personally I would leave that archaism in the last decade or even century.

-- 
With Best Regards,
Andy Shevchenko