Re: [PATCH] media: qcom: camss: csid: suppress CSID log spam

[Bryan O'Donoghue]

On 07/04/2025 09:51, Johan Hovold wrote:
> A recent commit refactored the printing of the CSID hardware version, but
> (without it being mentioned) also changed the log level from debug to
> info.
>
> This results in repeated log spam during use, for example, on the Lenovo
> ThinkPad X13s:
>
> 	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
> 	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
> 	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
> 	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
> 	qcom-camss ac5a000.camss: CSID:0 HW Version = 1.0.0
>
> Suppress the version logging by demoting to debug level again.
>
> Fixes: f759b8fd3086 ("media: qcom: camss: csid: Move common code into csid core")
> Cc: Depeng Shao <quic_depengs@xxxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> ---
>   drivers/media/platform/qcom/camss/camss-csid.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index d08117f46f3b..5284b5857368 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -613,8 +613,8 @@ u32 csid_hw_version(struct csid_device *csid)
>   	hw_gen = (hw_version >> HW_VERSION_GENERATION) & 0xF;
>   	hw_rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
>   	hw_step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
> -	dev_info(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n",
> -		 csid->id, hw_gen, hw_rev, hw_step);
> +	dev_dbg(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n",
> +		csid->id, hw_gen, hw_rev, hw_step);
>   
>   	return hw_version;
>   }
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>