Re: [PATCH v3 27/32] rtc: s5m: add support for S2MPG10 RTC

From: André Draszik
Date: Mon Apr 07 2025 - 05:35:10 EST


On Sun, 2025-04-06 at 20:33 +0200, Krzysztof Kozlowski wrote:
> You just sorted the MFD headers in other patch, but here you break the
> sorting.
>
> For me patches resorting the addresses (as a separate patch) is churn,
> but sure. If you do this however, it means you really believe that it is
> worth to sort them, so you must keep that standard for all your further
> patches in that series.

Definitely. Not sure how that happened :-(

>
> Rest is fine, so with this fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Thanks Krzysztof!

Cheers,
Andre'