Re: [PATCH 1/4] block: factor out a helper to set logical/physical block size

[Li Nan]

Hi, Bart:

Apologies for the delayed response.

在 2025/3/4 22:32, Bart Van Assche 写道:
> On 3/4/25 4:19 AM, linan666@xxxxxxxxxxxxxxx wrote:
> > +EXPORT_SYMBOL(blk_set_block_size);
>
> This function is exported without documenting what the requirements are
> for calling this function? Yikes.

Thank you for your reply, I'll add more
documentation in the next version.


> Is my understanding correct that it is only safe to apply changes made with 
> blk_set_block_size() by calling
> queue_limits_commit_update_frozen()?

Exported func blk_set_block_size() is only used in RAID, with expected
usage similar to queue_limits_stack_bdev(): callers must ensure no pending
IO and use queue_limits_start_update/queue_limits_commit_update to prevent
concurrent modifications.

> Thanks,
>
> Bart.
>
>
> .

--
Thanks,
Nan