[PATCH v3 4/8] iio: adc: ti-adc128s052: Use devm_mutex_init()
From: Matti Vaittinen
Date: Mon Apr 07 2025 - 07:36:41 EST
Quoting Jonathan:
"Whilst it doesn't bring huge advantage, now we have devm_mutex_init()
it seems reasonable to use it and maybe catch a use after free for the
lock"
Switch to use devm_mutex_init() while working on this file.
Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
---
v2 =>
- No changes
v1 => v2:
- Check the return value for the devm_mutex_init()
---
drivers/iio/adc/ti-adc128s052.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
index d0702d403fbe..d90a5caa028f 100644
--- a/drivers/iio/adc/ti-adc128s052.c
+++ b/drivers/iio/adc/ti-adc128s052.c
@@ -172,7 +172,9 @@ static int adc128_probe(struct spi_device *spi)
if (ret)
return ret;
- mutex_init(&adc->lock);
+ ret = devm_mutex_init(&spi->dev, &adc->lock);
+ if (ret)
+ return ret;
return devm_iio_device_register(&spi->dev, indio_dev);
}
--
2.49.0
Attachment:
signature.asc
Description: PGP signature