Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add Nvidia's GB200NVL BMC

From: Willie Thai
Date: Mon Apr 07 2025 - 09:23:47 EST


> On Tue, 2025-04-01 at 17:51 +0200, Krzysztof Kozlowski wrote:
> > On 01/04/2025 17:39, Willie Thai wrote:
> > > Add Nvidia's GB200NVL BMC board compatible.
> > >
> > > Co-developed-by: Mars Yang <maryang@xxxxxxxxxx>
> > > Signed-off-by: Mars Yang <maryang@xxxxxxxxxx>
> > > Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >
> > Why are you faking tags/email addresses? Read carefully submitting
> > patches. I really suggest using b4 instead of manually editing
> > things.
> > And if you decide for manual way, you must never, *never* edit
> > people's
> > tag. You can only copy and paste it.
>
> I've applied the series, fixing the tag in the process, along with the
> line-wrapping of the commit message in the second patch.
>
> Willie: scripts/checkpatch.pl warns of some of these things. Please
> make sure to use it in the future, or if you adopt b4 as Krzysztof
> suggests, use `b4 prep --check`.

Thanks Andrew !