Re: [PATCH 2/2] ice: add qsfp transceiver reset and presence pin control

[Kory Maincent]

On Mon,  7 Apr 2025 12:35:38 +0000
Marek Pazdan <mpazdan@xxxxxxxxxx> wrote:

> Commit f3c1c896f5a8 ("ethtool: transceiver reset and presence pin control")
> adds ioctl API extension for get/set-phy-tunable so that transceiver
> reset and presence pin control is enabled.

I don't think pointing and explaining the first commit is relevant here.

> This commit adds functionality to utilize the API in ice driver.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

You could simply write:
Add support for the newly introduced transceiver reset feature in the ice
driver.

> According to E810 datasheet QSFP reset and presence pins are being
> connected to SDP0 and SDP2 pins on controller host. Those pins can
> be accessed using AQ commands for GPIO get/set.[O

Weird character at the end.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com