Re: [PATCH v8 15/16] CXL/PCI: Enable CXL protocol errors during CXL Port probe
From: Bowman, Terry
Date: Mon Apr 07 2025 - 10:59:11 EST
On 4/4/2025 12:05 PM, Jonathan Cameron wrote:
> On Wed, 26 Mar 2025 20:47:16 -0500
> Terry Bowman <terry.bowman@xxxxxxx> wrote:
>
>> CXL protocol errors are not enabled for all CXL devices at boot. These
>> must be enabled inorder to process CXL protocol errors.
>>
>> Export the AER service driver's pci_aer_unmask_internal_errors().
>>
>> Introduce cxl_enable_port_errors() to call pci_aer_unmask_internal_errors().
>> pci_aer_unmask_internal_errors() expects the pdev->aer_cap is initialized.
>> But, dev->aer_cap is not initialized for CXL Upstream Switch Ports and CXL
>> Downstream Switch Ports. Initialize the dev->aer_cap if necessary. Enable AER
>> correctable internal errors and uncorrectable internal errors for all CXL
>> devices.
>>
>> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Thanks for reviewing.
Terry