Re: [PATCH 12/16] clk: lan966x: Add MCHP_LAN966X_PCI dependency

From: Andy Shevchenko
Date: Mon Apr 07 2025 - 11:47:45 EST


On Mon, Apr 07, 2025 at 04:55:41PM +0200, Herve Codina wrote:
> The lan966x clock controller depends on the LAN969x architecture or the
> LAN966x SoC.
>
> This clock controller can be used by the LAN966x PCI device and so it
> needs to be available when the LAN966x PCI device is enabled.

...

> depends on HAS_IOMEM
> depends on OF
> - depends on SOC_LAN966 || ARCH_LAN969X || COMPILE_TEST
> + depends on SOC_LAN966 || ARCH_LAN969X || MCHP_LAN966X_PCI || COMPILE_TEST

This doesn't seem to scale. Why not simply

depends on HAS_IOMEM
depends on OF || COMPILE_TEST

?

--
With Best Regards,
Andy Shevchenko