Re: [PATCH v5 00/35] GNR retirement latencies, topic and metric updates
From: Ian Rogers
Date: Mon Apr 07 2025 - 12:55:59 EST
On Wed, Apr 2, 2025 at 11:41 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Fri, Mar 28, 2025 at 12:16 PM Falcon, Thomas <thomas.falcon@xxxxxxxxx> wrote:
> >
> > On Fri, 2025-03-28 at 10:49 -0700, Ian Rogers wrote:
> > > Add default mean, min and max retirement latency values to GNR
> > > events. Update the topics on a number of events previously
> > > "other". Switch TMA metrics to the generated version. Add TMA 5.02
> > > metrics for sandybridge, ivytown, ivybridge and jaketown.
> > >
> > > Events and metrics generated from the data and scripts in:
> > > https://github.com/intel/perfmon
> > >
> > > v5: Additional metrics constraints from:
> > > https://github.com/intel/perfmon/pull/299
> > > PDIST descriptions added from:
> > > https://github.com/intel/perfmon/pull/292
> > > Original retirement latency, .. updates in:
> > > https://github.com/intel/perfmon/pull/298
> > >
> >
> > Metrics tests are passing on Granite Rapids, Arrow Lake and Alder Lake
> >
> > Tested-by: Thomas Falcon <thomas.falcon@xxxxxxxxx>
>
> Thanks Thomas, for Alderlake I ran into an issue fixed by:
> https://lore.kernel.org/lkml/20250402183806.3947021-1-irogers@xxxxxxxxxx/
Sorry, I was wrong that patch isn't necessary. There's a lot missing
from the perf-next tree that is in the google tree. Some of the
changes here are needed by:
https://lore.kernel.org/lkml/20250407050101.1389825-1-irogers@xxxxxxxxxx/
So it would be good to see these purely json file updates land with
Thomas' tested-by tag.
Thanks,
Ian
>
> > > v4: Generate grandridge metrics from the spreadsheet using conversion
> > > with the core type of crestmont.
> > >
> > > v3: Generate sierraforest metrics from the spreadsheet using
> > > conversion with the core type of crestmont.
> > >
> > > v2: Fix arrowlake PMU/cpu prefixes.
> > >
> > > Ian Rogers (35):
> > > perf vendor events: Update alderlake events/metrics
> > > perf vendor events: Update AlderlakeN events/metrics
> > > perf vendor events: Update arrowlake events/metrics
> > > perf vendor events: Update bonnell events
> > > perf vendor events: Update broadwell metrics
> > > perf vendor events: Update broadwellde metrics
> > > perf vendor events: Update broadwellx metrics
> > > perf vendor events: Update cascadelakex events/metrics
> > > perf vendor events: Update clearwaterforest events
> > > perf vendor events: Update elkhartlake events
> > > perf vendor events: Update emeraldrapids events/metrics
> > > perf vendor events: Update grandridge events/metrics
> > > perf vendor events: Add graniterapids retirement latencies
> > > perf vendor events: Update haswell metrics
> > > perf vendor events: Update haswellx metrics
> > > perf vendor events: Update icelake events/metrics
> > > perf vendor events: Update icelakex events/metrics
> > > perf vendor events: Update ivybridge metrics
> > > perf vendor events: Update ivytown metrics
> > > perf vendor events: Update jaketown metrics
> > > perf vendor events: Update lunarlake events/metrics
> > > perf vendor events: Update meteorlake events/metrics
> > > perf vendor events: Update nehalemep events
> > > perf vendor events: Update nehalemex events
> > > perf vendor events: Update rocketlake events/metrics
> > > perf vendor events: Update sandybridge metrics
> > > perf vendor events: Update sapphirerapids events/metrics
> > > perf vendor events: Update sierraforest events/metrics
> > > perf vendor events: Update skylake metrics
> > > perf vendor events: Update skylakex events/metrics
> > > perf vendor events: Update snowridgex events
> > > perf vendor events: Update tigerlake metrics
> > > perf vendor events: Update westmereep-dp events
> > > perf vendor events: Update westmereep-dp events
> > > perf vendor events: Update westmereep-dp events
> > >
> > > .../arch/x86/alderlake/adl-metrics.json | 489 +++++++--------
> > > .../pmu-events/arch/x86/alderlake/cache.json | 284 ++++++---
> > > .../arch/x86/alderlake/floating-point.json | 29 +-
> > > .../arch/x86/alderlake/frontend.json | 78 +--
> > > .../pmu-events/arch/x86/alderlake/memory.json | 82 ++-
> > > .../pmu-events/arch/x86/alderlake/other.json | 209 +------
> > > .../arch/x86/alderlake/pipeline.json | 308 +++++++---
> > > .../arch/x86/alderlake/virtual-memory.json | 43 +-
> > > .../arch/x86/alderlaken/adln-metrics.json | 54 +-
> > > .../pmu-events/arch/x86/alderlaken/cache.json | 107 +++-
> > > .../arch/x86/alderlaken/floating-point.json | 1 +
> > > .../arch/x86/alderlaken/memory.json | 50 ++
> > > .../pmu-events/arch/x86/alderlaken/other.json | 102 +---
> > > .../arch/x86/alderlaken/pipeline.json | 55 +-
> > > .../arch/x86/alderlaken/virtual-memory.json | 3 +
> > > .../arch/x86/arrowlake/arl-metrics.json | 566 +++++++++---------
> > > .../pmu-events/arch/x86/arrowlake/cache.json | 200 ++++++-
> > > .../arch/x86/arrowlake/frontend.json | 39 +-
> > > .../pmu-events/arch/x86/arrowlake/memory.json | 36 +-
> > > .../pmu-events/arch/x86/arrowlake/other.json | 197 +-----
> > > .../arch/x86/arrowlake/pipeline.json | 230 ++++++-
> > > .../pmu-events/arch/x86/bonnell/other.json | 8 -
> > > .../pmu-events/arch/x86/bonnell/pipeline.json | 8 +
> > > .../arch/x86/broadwell/bdw-metrics.json | 256 ++++----
> > > .../arch/x86/broadwellde/bdwde-metrics.json | 180 +++---
> > > .../arch/x86/broadwellx/bdx-metrics.json | 268 ++++-----
> > > .../arch/x86/cascadelakex/cache.json | 404 +++++++++++++
> > > .../arch/x86/cascadelakex/clx-metrics.json | 389 ++++++------
> > > .../arch/x86/cascadelakex/other.json | 404 -------------
> > > .../arch/x86/clearwaterforest/cache.json | 35 ++
> > > .../arch/x86/clearwaterforest/memory.json | 2 +
> > > .../arch/x86/clearwaterforest/other.json | 22 -
> > > .../arch/x86/clearwaterforest/pipeline.json | 6 +-
> > > .../arch/x86/elkhartlake/cache.json | 296 ++++++++-
> > > .../arch/x86/elkhartlake/floating-point.json | 1 +
> > > .../arch/x86/elkhartlake/memory.json | 261 ++++++++
> > > .../arch/x86/elkhartlake/other.json | 404 +------------
> > > .../arch/x86/elkhartlake/pipeline.json | 31 +-
> > > .../arch/x86/elkhartlake/virtual-memory.json | 4 +
> > > .../arch/x86/emeraldrapids/cache.json | 284 +++++++--
> > > .../arch/x86/emeraldrapids/emr-metrics.json | 475 +++++++--------
> > > .../x86/emeraldrapids/floating-point.json | 43 +-
> > > .../arch/x86/emeraldrapids/frontend.json | 78 +--
> > > .../arch/x86/emeraldrapids/memory.json | 231 ++++++-
> > > .../arch/x86/emeraldrapids/other.json | 332 +---------
> > > .../arch/x86/emeraldrapids/pipeline.json | 259 +++++---
> > > .../x86/emeraldrapids/virtual-memory.json | 40 +-
> > > .../pmu-events/arch/x86/grandridge/cache.json | 155 ++++-
> > > .../arch/x86/grandridge/counter.json | 2 +-
> > > .../arch/x86/grandridge/frontend.json | 8 +
> > > .../arch/x86/grandridge/grr-metrics.json | 204 ++++---
> > > .../arch/x86/grandridge/memory.json | 2 +
> > > .../pmu-events/arch/x86/grandridge/other.json | 29 +-
> > > .../arch/x86/grandridge/pipeline.json | 52 +-
> > > .../arch/x86/grandridge/uncore-cache.json | 45 +-
> > > .../arch/x86/grandridge/uncore-memory.json | 338 +++++++++++
> > > .../arch/x86/graniterapids/cache.json | 305 +++++++---
> > > .../arch/x86/graniterapids/counter.json | 5 +
> > > .../x86/graniterapids/floating-point.json | 43 +-
> > > .../arch/x86/graniterapids/frontend.json | 105 ++--
> > > .../arch/x86/graniterapids/gnr-metrics.json | 487 +++++++--------
> > > .../arch/x86/graniterapids/memory.json | 206 ++++++-
> > > .../arch/x86/graniterapids/other.json | 243 +-------
> > > .../arch/x86/graniterapids/pipeline.json | 261 +++++---
> > > .../arch/x86/graniterapids/uncore-cache.json | 42 ++
> > > .../graniterapids/uncore-interconnect.json | 90 ++-
> > > .../arch/x86/graniterapids/uncore-memory.json | 240 ++++++++
> > > .../x86/graniterapids/virtual-memory.json | 40 +-
> > > .../arch/x86/haswell/hsw-metrics.json | 206 ++++---
> > > .../arch/x86/haswellx/hsx-metrics.json | 222 ++++---
> > > .../pmu-events/arch/x86/icelake/cache.json | 60 ++
> > > .../arch/x86/icelake/icl-metrics.json | 385 ++++++------
> > > .../pmu-events/arch/x86/icelake/memory.json | 160 +++++
> > > .../pmu-events/arch/x86/icelake/other.json | 220 -------
> > > .../pmu-events/arch/x86/icelakex/cache.json | 273 +++++++++
> > > .../arch/x86/icelakex/icx-metrics.json | 399 ++++++------
> > > .../pmu-events/arch/x86/icelakex/memory.json | 190 ++++++
> > > .../pmu-events/arch/x86/icelakex/other.json | 463 --------------
> > > .../arch/x86/ivybridge/ivb-metrics.json | 76 ++-
> > > .../arch/x86/ivybridge/metricgroups.json | 5 +
> > > .../arch/x86/ivytown/ivt-metrics.json | 80 ++-
> > > .../arch/x86/ivytown/metricgroups.json | 5 +
> > > .../arch/x86/jaketown/frontend.json | 8 +
> > > .../arch/x86/jaketown/jkt-metrics.json | 40 +-
> > > .../arch/x86/jaketown/metricgroups.json | 5 +
> > > .../pmu-events/arch/x86/jaketown/other.json | 8 -
> > > .../pmu-events/arch/x86/lunarlake/cache.json | 182 +++++-
> > > .../arch/x86/lunarlake/frontend.json | 39 +-
> > > .../arch/x86/lunarlake/lnl-metrics.json | 560 ++++++++---------
> > > .../pmu-events/arch/x86/lunarlake/memory.json | 75 ++-
> > > .../pmu-events/arch/x86/lunarlake/other.json | 358 +----------
> > > .../arch/x86/lunarlake/pipeline.json | 253 +++++++-
> > > tools/perf/pmu-events/arch/x86/mapfile.csv | 14 +-
> > > .../pmu-events/arch/x86/meteorlake/cache.json | 352 ++++++++---
> > > .../arch/x86/meteorlake/floating-point.json | 28 +-
> > > .../arch/x86/meteorlake/frontend.json | 82 +--
> > > .../arch/x86/meteorlake/memory.json | 90 ++-
> > > .../arch/x86/meteorlake/mtl-metrics.json | 553 ++++++++---------
> > > .../pmu-events/arch/x86/meteorlake/other.json | 149 +----
> > > .../arch/x86/meteorlake/pipeline.json | 252 +++++---
> > > .../arch/x86/meteorlake/uncore-memory.json | 18 +
> > > .../arch/x86/meteorlake/virtual-memory.json | 40 +-
> > > .../pmu-events/arch/x86/nehalemep/cache.json | 32 +
> > > .../pmu-events/arch/x86/nehalemep/other.json | 40 --
> > > .../arch/x86/nehalemep/virtual-memory.json | 8 +
> > > .../pmu-events/arch/x86/nehalemex/cache.json | 32 +
> > > .../pmu-events/arch/x86/nehalemex/other.json | 40 --
> > > .../arch/x86/nehalemex/virtual-memory.json | 8 +
> > > .../pmu-events/arch/x86/rocketlake/cache.json | 60 ++
> > > .../arch/x86/rocketlake/memory.json | 160 +++++
> > > .../pmu-events/arch/x86/rocketlake/other.json | 220 -------
> > > .../arch/x86/rocketlake/rkl-metrics.json | 385 ++++++------
> > > .../arch/x86/sandybridge/frontend.json | 8 +
> > > .../arch/x86/sandybridge/metricgroups.json | 5 +
> > > .../arch/x86/sandybridge/other.json | 8 -
> > > .../arch/x86/sandybridge/snb-metrics.json | 36 +-
> > > .../arch/x86/sapphirerapids/cache.json | 343 ++++++++---
> > > .../x86/sapphirerapids/floating-point.json | 43 +-
> > > .../arch/x86/sapphirerapids/frontend.json | 78 +--
> > > .../arch/x86/sapphirerapids/memory.json | 231 ++++++-
> > > .../arch/x86/sapphirerapids/other.json | 382 +-----------
> > > .../arch/x86/sapphirerapids/pipeline.json | 259 +++++---
> > > .../arch/x86/sapphirerapids/spr-metrics.json | 469 ++++++++-------
> > > .../x86/sapphirerapids/virtual-memory.json | 40 +-
> > > .../arch/x86/sierraforest/cache.json | 25 +
> > > .../arch/x86/sierraforest/memory.json | 24 +
> > > .../arch/x86/sierraforest/other.json | 49 +-
> > > .../arch/x86/sierraforest/pipeline.json | 9 +
> > > .../arch/x86/sierraforest/srf-metrics.json | 204 ++++---
> > > .../arch/x86/sierraforest/uncore-cache.json | 32 +
> > > .../arch/x86/sierraforest/uncore-memory.json | 240 ++++++++
> > > .../arch/x86/skylake/skl-metrics.json | 367 ++++++------
> > > .../pmu-events/arch/x86/skylakex/cache.json | 74 +++
> > > .../pmu-events/arch/x86/skylakex/other.json | 74 ---
> > > .../arch/x86/skylakex/skx-metrics.json | 385 ++++++------
> > > .../pmu-events/arch/x86/snowridgex/cache.json | 296 ++++++++-
> > > .../arch/x86/snowridgex/floating-point.json | 1 +
> > > .../arch/x86/snowridgex/memory.json | 261 ++++++++
> > > .../pmu-events/arch/x86/snowridgex/other.json | 404 +------------
> > > .../arch/x86/snowridgex/pipeline.json | 31 +-
> > > .../arch/x86/snowridgex/virtual-memory.json | 4 +
> > > .../arch/x86/tigerlake/tgl-metrics.json | 383 ++++++------
> > > .../arch/x86/westmereep-dp/cache.json | 32 +
> > > .../arch/x86/westmereep-dp/other.json | 40 --
> > > .../x86/westmereep-dp/virtual-memory.json | 8 +
> > > .../arch/x86/westmereep-sp/cache.json | 32 +
> > > .../arch/x86/westmereep-sp/other.json | 40 --
> > > .../x86/westmereep-sp/virtual-memory.json | 8 +
> > > .../pmu-events/arch/x86/westmereex/cache.json | 32 +
> > > .../pmu-events/arch/x86/westmereex/other.json | 40 --
> > > .../arch/x86/westmereex/virtual-memory.json | 8 +
> > > 151 files changed, 12770 insertions(+), 9855 deletions(-)
> > > delete mode 100644 tools/perf/pmu-events/arch/x86/clearwaterforest/other.json
> > >
> >