Re: [PATCH v2 07/18] drm/bridge: cdns-dsi: Fail if HS rate changed when validating PHY config
From: Aradhya Bhatia
Date: Mon Apr 07 2025 - 13:27:24 EST
On 02/04/25 19:00, Tomi Valkeinen wrote:
> The phy_validate() can change the HS clock rate we passed to it in the
> PHY config, depending on what the HW can actually do. The driver just
> ignores this at the moment, but if the actual HS clock rate is different
> than the requested one, the pipeline will fail as all the DSI timing
> calculations will be incorrect.
>
> There are ways to improve DSI operation for various clock rates, but for
> now, just add a check to see if the rate changed, and return an error if
> that happens.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Reviewed-by: Aradhya Bhatia <aradhya.bhatia@xxxxxxxxx>
--
Regards
Aradhya