Re: [PATCH v3 5/5] media: platform: qcom/iris: add sm8650 support

[Neil Armstrong]

On 07/04/2025 17:52, Bryan O'Donoghue wrote:
> On 07/04/2025 16:24, Neil Armstrong wrote:
> > Add support for the SM8650 platform by re-using the SM8550
> > definitions and using the vpu33 ops.
> >
> > The SM8650/vpu33 requires more reset lines, but the H.284
>
> h264.
>
> > decoder capabilities are identical.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../platform/qcom/iris/iris_platform_common.h      |  1 +
> >   .../platform/qcom/iris/iris_platform_sm8550.c      | 64 ++++++++++++++++++++++
> >   drivers/media/platform/qcom/iris/iris_probe.c      |  4 ++
> >   3 files changed, 69 insertions(+)
> >
> > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
> > index fdd40fd80178c4c66b37e392d07a0a62f492f108..6bc3a7975b04d612f6c89206eae95dac678695fc 100644
> > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
> > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
> > @@ -35,6 +35,7 @@ enum pipe_type {
> >
> >   extern struct iris_platform_data sm8250_data;
> >   extern struct iris_platform_data sm8550_data;
> > +extern struct iris_platform_data sm8650_data;
> >
> >   enum platform_clk_type {
> >       IRIS_AXI_CLK,
> > diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
> > index 35d278996c430f2856d0fe59586930061a271c3e..d0f8fa960d53367023e41bc5807ba3f8beae2efc 100644
> > --- a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
> > +++ b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c
> > @@ -144,6 +144,10 @@ static const struct icc_info sm8550_icc_table[] = {
> >
> >   static const char * const sm8550_clk_reset_table[] = { "bus" };
> >
> > +static const char * const sm8650_clk_reset_table[] = { "bus", "core" };
> > +
> > +static const char * const sm8650_controller_reset_table[] = { "xo" };
>
>
> At the risk of asking a stupid question, where are these resets in your dts ?
>
> You're missing core here ?
>
> 20250407-topic-sm8x50-upstream-iris-8550-dt-v1-1-1f7ab3083f49@xxxxxxxxxx

This one if for sm8550, this very patch is adding support for sm8650 which needs core & xo in addition to bus

Neil

> ---
> bod