Re: [PATCH 0/7] iio: convert GPIO chips to using new value setters
From: Jonathan Cameron
Date: Mon Apr 07 2025 - 15:32:13 EST
On Mon, 07 Apr 2025 09:18:08 +0200
Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. We're in the process of
> converting all GPIO drivers to using the new API. This series converts
> all the IIO GPIO controllers and also contains some additional
> refactoring patches for ad5592r in preparation for the conversion.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
Nice. All the _rv patches look good to me. Just a few minor things
on the precursors. One other driver crossed with this, but Matti has
posted a patch updating that one as well.
https://lore.kernel.org/all/Z_N_J52IZ2IaWawl@mva-rohm/
Thanks,
Jonathan
> ---
> Bartosz Golaszewski (7):
> iio: dac: ad5592r: destroy mutexes in detach paths
> iio: dac: ad5592r: use lock guards
> iio: dac: ad5592r: use new GPIO line value setter callbacks
> iio: adc: ti-ads7950: use new GPIO line value setter callbacks
> iio: adc: ad4130: use new GPIO line value setter callbacks
> iio: addac: ad74413r: use new GPIO line value setter callbacks
> iio: addac: ad74115: use new GPIO line value setter callbacks
>
> drivers/iio/adc/ad4130.c | 10 ++--
> drivers/iio/adc/ti-ads7950.c | 17 ++++--
> drivers/iio/addac/ad74115.c | 18 +++---
> drivers/iio/addac/ad74413r.c | 28 ++++-----
> drivers/iio/dac/ad5592r-base.c | 132 +++++++++++++++++------------------------
> 5 files changed, 95 insertions(+), 110 deletions(-)
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250401-gpiochip-set-rv-iio-b064ce43791d
>
> Best regards,