Re: [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`

[Andrew Lunn]

> +static const struct dlink_stats stats[] = {
> +	{
> +		.string = "tx_jumbo_frames",
> +		.stat_offset = offsetof(struct netdev_private,
> +					tx_jumbo_frames),
> +		.size = sizeof(u16),
> +		.regs = TxJumboFrames
> +	},
> +	{
> +		.string = "rmon_rx_packets",
> +		.stat_offset = offsetof(struct netdev_private,
> +					rmon_rx_packets),
> +		.size = sizeof(u32),
> +		.regs = EtherStatsPkts
> +	}
> +}, ctrl_stats[] = {
> +	{
> +		.string = "tx_mac_control_frames",

That is an odd way of doing it. It would be better to repeat the
static const struct dlink_stats.

       Andrew