RE: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

[Keller, Jacob E]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Monday, April 7, 2025 1:19 PM
> To: Parvathi Pudi <parvathi@xxxxxxxxxxx>
> Cc: danishanwar@xxxxxx; rogerq@xxxxxxxxxx; andrew+netdev@xxxxxxx;
> davem@xxxxxxxxxxxxx; Dumazet, Eric <edumazet@xxxxxxxxxx>;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; nm@xxxxxx; ssantosh@xxxxxxxxxx; tony@xxxxxxxxxxx;
> richardcochran@xxxxxxxxx; glaroque@xxxxxxxxxxxx; schnelle@xxxxxxxxxxxxx;
> m-karicheri2@xxxxxx; rdunlap@xxxxxxxxxxxxx; diogo.ivo@xxxxxxxxxxx;
> basharath@xxxxxxxxxxx; horms@xxxxxxxxxx; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; m-malladi@xxxxxx; javier.carrasco.cruz@xxxxxxxxx;
> afd@xxxxxx; s-anna@xxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; pratheesh@xxxxxx;
> prajith@xxxxxx; vigneshr@xxxxxx; praneeth@xxxxxx; srk@xxxxxx; rogerq@xxxxxx;
> krishna@xxxxxxxxxxx; pmohan@xxxxxxxxxxx; mohan@xxxxxxxxxxx
> Subject: Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for
> ICSSM PRUETH Driver
> 
> > +#define PRUETH_MODULE_VERSION "0.2"
> 
> > +static void icssm_emac_get_drvinfo(struct net_device *ndev,
> > +				   struct ethtool_drvinfo *info)
> > +{
> > +	strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info-
> >driver));
> > +	strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version));
> 
> Driver version numbers are pointless, they never change, but the
> kernel is changing all the time. Leave version blank, and the core
> will fill in the kernel version, which is useful.
> 
>      Andrew

It is also a long standing policy that in-tree drivers should not have versions separate from the kernel version.

Thanks,
Jake