Re: [PATCH 7/9] dt-bindings: i2c: dw: Add Sophgo SG2044 SoC I2C controller

[Inochi Amaoto]

On Mon, Apr 07, 2025 at 09:02:32AM -0500, Rob Herring wrote:
> On Mon, Apr 07, 2025 at 09:06:12AM +0800, Inochi Amaoto wrote:
> > Add compatible string for Sophgo SG2044 SoC I2C controller which can be
> > used specifically for the SG2044 SoC.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> > ---
> >  .../devicetree/bindings/i2c/snps,designware-i2c.yaml          | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > index bc5d0fb5abfe..677b39865af0 100644
> > --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
> > @@ -38,6 +38,10 @@ properties:
> >            - const: snps,designware-i2c
> >        - description: Baikal-T1 SoC System I2C controller
> >          const: baikal,bt1-sys-i2c
> > +      - description: Sophgo SoCs I2C controller
> > +        items:
> > +          - const: sophgo,sg2044-i2c
> > +          - const: snps,designware-i2c
> 
> This is not a great pattern we've started. T-HEAD, Ocelot, and this 
> should all be combined into 1 enum. The description here is not that 
> useful.
> 

I agree and am fine to do this.

Regard,
Inochi