Re: [PATCH] drm/amd/pm/smu11: Prevent division by zero
From: Denis Arefev
Date: Tue Apr 08 2025 - 04:26:42 EST
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
> index 189c6a32b6bd..54229b991858 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
> @@ -1200,7 +1200,7 @@ int smu_v11_0_set_fan_speed_rpm(struct smu_context *smu,
> uint32_t crystal_clock_freq = 2500;
> uint32_t tach_period;
>
> - if (speed == 0)
> + if (!speed || speed > UINT_MAX/8)
> return -EINVAL;
> /*
> * To prevent from possible overheat, some ASICs may have requirement
> --
> 2.43.0
>
Hi Alex.
The patch 'drm/amd/pm/smu11: Prevent division by zero' was sent
separately, not part of the patch series, maybe that's why it wasn't
accepted. Should I resend it?
Regards, Denis.